search

woodpecker-ci / woodpecker

Woodpecker is a simple yet powerful CI/CD engine with great extensibility.
https://woodpecker-ci.org
Apache License 2.0
3.88k stars 345 forks source link

WIP: remove some ci environment variables #3846

Open 6543 opened 1 week ago

6543 commented 1 week ago

remove some environment variables who are either the same value or make no sense to exist in the first place:

CI_STEP_STATUS CI_STEP_FINISHED CI_PIPELINE_STATUS CI_PIPELINE_FINISHED

anbraten commented 1 week ago

Could we remove those things just-in-time when we release 3.0. Those PRs will probably be quite outdated and need updates as we are constantly adding new deprecations til we release 3.0.

qwerty287 commented 6 days ago

We should do 3.0 soon I think. There are enough breaing changes and deprecations collected. Maybe after 2.7.0?

anbraten commented 6 days ago

We should do 3.0 soon I think. There are enough breaing changes and deprecations collected. Maybe after 2.7.0?

I would like to like to do it earliest end of the year. We should provide the community some time between major releases and the breaking changes we would currently apply aren't that critical IMO and the benefits from a users perspective are rather minimal atm.

zc-devs commented 6 days ago

I would add DRONE_* to the list.

qwerty287 commented 6 days ago

We keep the drone vars to be compatible to drone plugins.

6543 commented 6 days ago

... Those PRs will probably be quite outdated and need updates as we are constantly adding new deprecations til we release 3.0.

yes I just want to start adding the changes here and I'll peridically resolve conflicts and update it etc ... as it's easuly forgotten otherwise