woodpecker-ci / woodpecker

Woodpecker is a simple yet powerful CI/CD engine with great extensibility.
https://woodpecker-ci.org
Apache License 2.0
3.88k stars 345 forks source link

Commands can leak into image, image cannot be pulled #3856

Open zc-devs opened 4 days ago

zc-devs commented 4 days ago

Component

server

Describe the bug

When the one forgot commands directive, then they join to image => image cannot be pulled, pipeline stucks.

Steps to reproduce

  1. Create and run pipeline
    
    skip_clone: true

when:

steps: hello: image: alpine

Expected behavior

Pipeline should fail and linter should warn about missed commands as well.

System Info

`2.6.0`, Kubernetes

Additional context

woodpecker-server.log woodpecker-agent.log

Validations

zc-devs commented 4 days ago

In regard Kubernets backend, probably, wider range of statuses should be chacked (https://github.com/woodpecker-ci/woodpecker/pull/3580).