woodpecker-ci / woodpecker

Woodpecker is a simple, yet powerful CI/CD engine with great extensibility.
https://woodpecker-ci.org
Apache License 2.0
4.28k stars 369 forks source link

Prohibit image usage in local backend #3997

Open zc-devs opened 3 months ago

zc-devs commented 3 months ago

Clear and concise description of the problem

Currently, image clause is used as a path to the executable.

Suggested solution

Use entrypoint or introduce new special clause for Local backend.

Alternative

Get rid of image and use only commands.

Additional context

https://github.com/woodpecker-ci/woodpecker/discussions/3263#discussioncomment-8233224 (point N3)

Validations

qwerty287 commented 3 months ago

This needs a depreciation first, can't be removed in 3.0 directly.

Also, something to note: the schema currently says the image is required. We would need to drop that and that makes it less helpful cod linting.

Get rid of image and use only commands.

This should not be done because you can't use a command like export x=y then anymore.

zc-devs commented 3 months ago

This needs a depreciation first, can't be removed in 3.0 directly

Sad, but OK.

The main point is to get rid of confusing image. Do something like environment was removed from plugins and schema was corrected (#3909). So, there is entrypoint for shell and commands for whatever else, then.

zc-devs commented 6 days ago

https://docs.drone.io/pipeline/exec/syntax/steps/