Docker Windows Agent

[cduchenoy]

Component

agent

Describe the bug

From version > 2.6.1 bind mount workspace failed

Steps to reproduce

1. install woodpecker docker agent (windows) > 2.6.0
2. run an ci

Expected behavior

No response

System Info

{
source: "https://github.com/woodpecker-ci/woodpecker",
version: "2.6.0"
}

Additional context

First of all: Thank you very much for this useful tool!

For a client we ported the containers (agent, plugin-git) and added one base-step (with chocolatey installed) to Microsoft Windows.

For more information, see https://github.com/GECO-IT/woodpecker-windows

We encounter 2 problems:

1 From agent version > 2.6.0, we have a problem mounting volumes in plugins.

Before this release, we could work around the docker error by adding

---
...
workspace:
  base: C:\tmp
..

We believe this error comes from PR #3933.

2 With the trustedClonePlugins variable https://github.com/woodpecker-ci/woodpecker/blob/main/shared/constant/constant.go

We need to retag our local plugin-git image: “woodpeckerci/plugin-git” to keep netrc secure!

Do you think you could include Windows images officially?

For information: we have also include an installer for local backend on Windows.

Best regards Cyril DUCHENOY Geco-iT

Validations

• [X] Read the docs.
• [X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
• [X] Checked that the bug isn't fixed in the next version already [https://woodpecker-ci.org/faq#which-version-of-woodpecker-should-i-use]

[6543]

this most likely has to do with https://github.com/woodpecker-ci/woodpecker/pull/3933 witch was done because of https://github.com/woodpecker-ci/woodpecker/issues/3924

[cduchenoy]

Yes you right, perhaps we can add "C:\" as a prefix to the bind mount if the agent is of the windows/xxx type?

[6543]

I would say if workflow workspace has C:\ prefix we do add it there too ...

... feel free to create a pull

[6543]

Hmm also if labels platform has windows ... but in any case this is an heuristic and should be an own function

checkRunOnWindowsHeuristics(...) bool witch will then add the prefix on true

-> there is no 100% pervect solution :/

[6543]

Do you think you could include Windows images officially?

Do you have an source of your windows git clone plugin ... it's an open issue for our plugin ...

[cduchenoy]

Yes in the same repo https://github.com/GECO-IT/woodpecker-windows/tree/main/plugins/plugin-git

[cduchenoy]

We just dockerize the official plugin under windows

[cduchenoy]

for agent https://github.com/GECO-IT/woodpecker-windows/blob/main/agent/backend-docker/Dockerfile.Windows