Woodpecker `2.7.2` broke login auth redirects, always returns blank page.

woodpecker-ci / woodpecker

Woodpecker is a simple, yet powerful CI/CD engine with great extensibility.

https://woodpecker-ci.org

Apache License 2.0

4.31k stars 371 forks source link

Woodpecker `2.7.2` broke login auth redirects, always returns blank page. #4294

Closed dessalines closed 3 weeks ago

dessalines commented 3 weeks ago

Component

server

Describe the bug

With the 2.7.1 -> 2.7.2 upgrade, woodpecker always returns a blank page. It seems to be trying to redirect to the /login?url=/repos page, but returns a blank page

Steps to reproduce

Have a working 2.7.1 install
Upgrade to 2.7.2
All pages are blank, and the loging redirect fails.

Expected behavior

It should correctly handle login redirects

System Info

`"source":"https://github.com/woodpecker-ci/woodpecker","version":"2.7.2"}`

Luckily there were no migrations as far as I can tell, so switching back to the v2.7.1 docker tag seems to be working fine.

Additional context

Validations

[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Checked that the bug isn't fixed in the next version already [https://woodpecker-ci.org/faq#which-version-of-woodpecker-should-i-use]

zc-devs commented 3 weeks ago

Perhaps, related #4194

devlux commented 3 weeks ago

same here

sinlov commented 3 weeks ago

it look like https://woodpecker.foo/api/stream/events api error

strict-origin-when-cross-origin

Browser console error

index-KaW5c5Z3.js:14 SyntaxError (at index-KaW5c5Z3.js:30:2267)
    at Ja (index-KaW5c5Z3.js:30:2267)
    at bt (index-KaW5c5Z3.js:40:798)
    at ue (index-KaW5c5Z3.js:40:4679)
    at Object.pe [as t] (index-KaW5c5Z3.js:40:4736)
    at setup (Login-RBNwZx3k.js:1:1138)
    at ca (index-KaW5c5Z3.js:14:38)
    at _p (index-KaW5c5Z3.js:14:38755)
    at pp (index-KaW5c5Z3.js:14:38538)
    at K (index-KaW5c5Z3.js:14:22424)
    at B (index-KaW5c5Z3.js:14:22316)

Sn0w3y commented 3 weeks ago

Yes, can confirm, same issue here ! :)

Possible, that this issue occurs if running only behind a Reverse Proxy ?

fabienengels commented 3 weeks ago

Got the same issue using Caddy as reverse proxy

romain-rossi commented 3 weeks ago

Same issue using Traefik (Kubernetes Ingress) as reverse proxy

pat-s commented 3 weeks ago

As @zc-devs stated, it likely due to #4194, which required a dep update (#4197) to get fixed. This wasn't backported to 2.7.2, so this release is broken and unusable.

sierja commented 2 weeks ago

If this has been fixed, and thus closed, when can we expect a fixed release?

Sn0w3y commented 2 weeks ago

If this has been fixed, and thus closed, when can we expect a fixed release?

Same question here

adamcstephens commented 2 weeks ago

Did you try the new release, 2.7.3? Because the linked PR was included in that.

gramakri commented 2 weeks ago

We updated the Cloudron woodpecker package. Can confirm the issue is fixed with 2.7.3