woodpecker-ci / woodpecker

Woodpecker is a simple, yet powerful CI/CD engine with great extensibility.
https://woodpecker-ci.org
Apache License 2.0
4.3k stars 371 forks source link

Add server configuration option to add default set of labels for workflows that has no labels specified #4326

Closed lafriks closed 1 week ago

lafriks commented 2 weeks ago

Fixes #4324 Probably fixes #2634

Have not tested yet but wanted to open to get initial feedback

woodpecker-bot commented 2 weeks ago

Deployment of preview was torn down

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 16.00000% with 21 lines in your changes missing coverage. Please review.

Project coverage is 27.37%. Comparing base (f4d7e9f) to head (3be2ff4). Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
server/pipeline/items.go 0.00% 11 Missing :warning:
cmd/server/setup.go 0.00% 10 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #4326 +/- ## ========================================== - Coverage 27.37% 27.37% -0.01% ========================================== Files 380 380 Lines 27781 27794 +13 ========================================== + Hits 7606 7608 +2 - Misses 19490 19501 +11 Partials 685 685 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

lafriks commented 1 week ago

I'm already running this in our production (cherry-picked on v2.7.1) and currently all seems to work as expected so I think it's ready to review