search

woodpecker-ci / woodpecker

Woodpecker is a simple, yet powerful CI/CD engine with great extensibility.
https://woodpecker-ci.org
Apache License 2.0
4.3k stars 371 forks source link

Fix avatar column type #4340

Closed qwerty287 closed 1 week ago

qwerty287 commented 1 week ago

closes #4278

zc-devs commented 1 week ago

I know, the issue is about avatar, but there is email with the same "bug".

xoxys commented 1 week ago

Does it require a migration? Or what happens with existing tables?

qwerty287 commented 1 week ago

While it might be possible to have an email longer than 255 chars, I think we can also just ignore that... If we increase that to 500, it wouldn't really help as you still have a limit that's just higher. Nobody really has an email longer 255 chars (or, if you have, you should really ask why 😂).

But I get your point, and usually, I also prefer solutions that cover any possible usecase.

Edit: just saw that user's email also has 500. So I'll just increase it here as well.

qwerty287 commented 1 week ago

Does it require a migration? Or what happens with existing tables?

AFAIK xorm updates types like this automatically.

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 26.55%. Comparing base (bf5405b) to head (5f46f26). Report is 7 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #4340 +/- ## ========================================== - Coverage 26.55% 26.55% -0.01% ========================================== Files 379 379 Lines 27548 27555 +7 ========================================== Hits 7316 7316 - Misses 19563 19570 +7 Partials 669 669 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

woodpecker-bot commented 1 week ago

Tearing down https://woodpecker-ci-woodpecker-pr-4340.surge.sh