when.status:failure doesn't work across workflows (runs_on:failure)

[zc-devs]

Component

server

Describe the bug

Step with when.status: [failure] doesn't run on failed pipeline, instead runs step with when.status: [success].

Steps to reproduce

1. Woodpecker + some Forge
2. Make a pipeline

# build.yaml
skip_clone: true
steps:
  build:
    image: alpine
    commands:
      - echo 'Building the app'
      - exit 1 # 0 - success, 1 - fail

# notifications.yaml
skip_clone: true
depends_on: [build]
runs_on: [success, failure]
steps:
  fail-notification:
    when:
      - status: [failure]
    image: alpine
    commands:
      - echo 'Build failed'
  success-notification:
    when:
      - status: [success]
    image: alpine
    commands:
      - echo 'Build succeed'

3. Run manually and get wrong step execution

Expected behavior

1. fail-notification step runs
2. success-notification skips

System Info

WP `next-f87e80381b`, `2.7.1`, Gitea, Postgres 16

Additional context

https://github.com/woodpecker-ci/woodpecker/issues/4337#issuecomment-2468498847

Validations

• [X] Read the docs.
• [X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
• [X] Checked that the bug isn't fixed in the next version already [https://woodpecker-ci.org/faq#which-version-of-woodpecker-should-i-use]

[pat-s]

It works within a pipeline but not across, hence the title should likely be updated to include this condition/detail.