search

woodpecker-ci / woodpecker

Woodpecker is a simple, yet powerful CI/CD engine with great extensibility.
https://woodpecker-ci.org
Apache License 2.0
4.3k stars 371 forks source link

Deprecate and warn of list syntax of environment #4358

Closed 6543 closed 5 days ago

6543 commented 1 week ago

Close #4306

also better detection of secrets legacy syntax

xoxys commented 1 week ago

Shouldn't this PR go to main first and the backported to release/v2.8?

6543 commented 1 week ago

@xoxys well that's exactly what this pull try to solve. in main, the environment syntax already got removed completely! but it was never deprecated before - so this pull does so for the next release those targeting the release branch

xoxys commented 1 week ago

Ah ok sorry, got it 👍 I think thats because the plan was to release 3.0 next.

6543 commented 1 week ago

No the plan was to release v2.8.0 as the legacy environment syntax is currently completly valid in the latest release.

And pipeline congig changes must be depricated before a next release is allowed to let it error out.

Those this pull is needed and ned to be released before next release made from main e.g. 3.0.0

Those a 2.8.0 must be released containing a deprication

This pull does tje deprication