woodpecker-ci / woodpecker

Woodpecker is a simple, yet powerful CI/CD engine with great extensibility.
https://woodpecker-ci.org
Apache License 2.0
4.3k stars 371 forks source link

Improve error message for wrong secrets / environment config #4359

Closed 6543 closed 1 week ago

6543 commented 1 week ago

also address https://github.com/woodpecker-ci/woodpecker/issues/4306

Before

image image

After

image image

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 91.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 27.37%. Comparing base (a1193f0) to head (26e8f2f). Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
pipeline/frontend/yaml/types/base/deprecations.go 91.66% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #4359 +/- ## ========================================== + Coverage 27.32% 27.37% +0.05% ========================================== Files 379 380 +1 Lines 27757 27781 +24 ========================================== + Hits 7584 7606 +22 - Misses 19488 19490 +2 Partials 685 685 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

xoxys commented 1 week ago

Shouldn't it go to the changelog? Or why have you set the skip-changelog label?

6543 commented 1 week ago

this not as it just improves an already existing error message ... folowups in this area do

woodpecker-bot commented 1 week ago

Tearing down https://woodpecker-ci-woodpecker-pr-4359.surge.sh