Remove `secrets` in favor of `from_secret`

[6543]

should only be merged if https://github.com/woodpecker-ci/woodpecker/pull/4360 got merged

close #4413

depend on #4407

[6543]

All dependencys are merged ...

[pat-s]

@qwerty287 If you want the error to be changed but have no time/motivation, please don't approve as otherwise it will not be changed and merged as-is.

[zc-devs]

What's the purpose of deprecation? (warn the users) Was it done properly? (yes) What's the purpose of removing? (clean the code)

So, I suggest to remove it completely and just write release and migration notes.

[qwerty287]

@qwerty287 If you want the error to be changed but have no time/motivation, please don't approve as otherwise it will not be changed and merged as-is.

I meant that the error is fine for me, but from similar PRs I know that you usually have some improvements.

[pat-s]

Fair enough for now, I still think that adding a : to such statements makes it more clear/easier for users.

[6543]

we had 3 lgtms ... but they got dismissed after a code fix :/

[codecov[bot]]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 27.62%. Comparing base (5c22047) to head (d3a76dd). Report is 8 commits behind head on main.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #4363 +/- ## ========================================== + Coverage 27.58% 27.62% +0.03% ========================================== Files 382 381 -1 Lines 27922 27894 -28 ========================================== + Hits 7703 7705 +2 + Misses 19532 19505 -27 + Partials 687 684 -3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

---

🚨 Try these New Features:

• Flaky Tests Detection - Detect and resolve failed and flaky tests
• JS Bundle Analysis - Avoid shipping oversized bundles

[woodpecker-bot]

Tearing down https://woodpecker-ci-woodpecker-pr-4363.surge.sh