search

woodpecker-ci / woodpecker

Woodpecker is a simple, yet powerful CI/CD engine with great extensibility.
https://woodpecker-ci.org
Apache License 2.0
4.3k stars 370 forks source link

Refactor: move pipeline compilers getSecretValue() into an compiler Option #4378

Open 6543 opened 1 week ago

6543 commented 1 week ago

https://github.com/woodpecker-ci/woodpecker/blob/1c7728fae3b5f2f6ce99580066bed6b2f98167d2/pipeline/frontend/yaml/compiler/convert.go#L101 https://github.com/woodpecker-ci/woodpecker/blob/1c7728fae3b5f2f6ce99580066bed6b2f98167d2/pipeline/frontend/yaml/compiler/compiler.go#L97

instead of definding on the fly func and passing al secrets onto the compiler, we can inject an function that can directly query the database ... and for cli the args etc...

6543 commented 1 week ago

NOTE: if #3723 merged should als be done for it

6543 commented 2 days ago

-> https://github.com/woodpecker-ci/woodpecker/pull/4384 well a simple function wont do ... we should adjust and add a SecretService