woodpecker-ci / woodpecker

Woodpecker is a simple, yet powerful CI/CD engine with great extensibility.
https://woodpecker-ci.org
Apache License 2.0
4.31k stars 372 forks source link

Improve linter output for `secret:` deprecation #4413

Closed pat-s closed 3 days ago

pat-s commented 5 days ago

Component

web-ui

Describe the bug

If one has secrets: specified in WP next instead of using environment: SECRET from_secret: etc, the following linter message is shown

image

This is quite confusing.

I'd argue that

Steps to reproduce

.

Expected behavior

.

System Info

next

Additional context

No response

Validations

zc-devs commented 5 days ago

Using

Using by whom? Woodpecker won't process it, if I understand correctly.

deprecated secrets: notation please use define the secret in environment: instead using the from_secret: syntax

When it was deprecated, it was like you proposed. Now (in 3.0) it is not allowed.

6543 commented 4 days ago

-> https://github.com/woodpecker-ci/woodpecker/pull/4363