search

woodpecker-ci / woodpecker

Woodpecker is a simple, yet powerful CI/CD engine with great extensibility.
https://woodpecker-ci.org
Apache License 2.0
4.3k stars 370 forks source link

Add icons to all pipeline tabs #4421

Open xoxys opened 1 day ago

xoxys commented 1 day ago

I would like to add icons to all tabs in pipeline view (and later on also in other views). In my opinion it looks better and results in a consistent look, especially on mobile where tabs are displayed in vertically.

@woodpecker-ci/maintainers as this might be another controversial design decision, please vote on the initial post of this PR with :+1: and :-1:

Desktop: image

Mobile:

pat-s commented 1 day ago

I like the idea but don't like the icon choice in the screenshot too much.

Thanks for starting with a poll right away. It might be that we need a separate one for each icon 😅️

pat-s commented 1 day ago

Here are some possible alternatives up for discussion:

xoxys commented 1 day ago

Thanks for the feedback.

I had something in mind while choosing exactly these icons. I was looking for icons that somehow fit together semantically. I started with a stack of sheets aka workflows/tasks. A single sheet from the stack should symbolize a part of the config. Thats why I chose the paper sheet icons for the config (I definetly want to avoid using the gear as this is used for settings already) and the config parsing issues. The last icon for debugging was the closest I found that looks like "inspecting a sheet" (aka workflow/task). Last but not least all icons have a similar shape to avoid a too chaotic and distracting look.

Sure there might be "better" icons for each tab but I dont know if that should be the only criteria but Im also not a professional ui designer :)

Nevertheless Im not interested in months of discussions for single icons we have too much of them. It that is the outcome thats totally fine but then Ill leave this task to someone else :)

pat-s commented 17 hours ago

I had something in mind while choosing exactly these icons. I was looking for icons that somehow fit together semantically.

OK, didn't know that :)

Let's see what others think!

m also not a professional ui designer :)

None of us is, so no worries. I guess most people just follow their gut feeling which might be more or less matching with others.

xoxys commented 17 hours ago

OK, didn't know that :)

How could you :) Don't want to blame anyone. If you don't like the icons, that perfectly fine.