search

woodpecker-ci / woodpecker

Woodpecker is a simple, yet powerful CI/CD engine with great extensibility.
https://woodpecker-ci.org
Apache License 2.0
4.07k stars 351 forks source link

Only set Commit status "error" on pipeline error #459

Closed 6543 closed 2 years ago

6543 commented 2 years ago

example https://ci.codeberg.org/crapsilon/JAMMM/1

do NOT set an ci status for related commit

anbraten commented 2 years ago

@6543 Do you want woodpecker to NOT report a status at all if the pipeline was not running at all caused by an error in the config etc? Or should it be pending?

6543 commented 2 years ago

if pipeline is skiped none if error occur -> error

anbraten commented 2 years ago

🤔 I don't know if this would be ideal. A user wont get any feedback that way. For example in a PR he wont see that something was failing as the UI would not show a CI status at all (if status check is not required by repo settings). Second problem is the fact that a PR could be merged as the CI is not blocking if not required.

6543 commented 2 years ago

well skiped pipeline should not create status: -> on main branch they are normaly intendent to save ci time -> on pull it should not create a status as otherwhies branch protection could be missed

6543 commented 2 years ago

.. the fact that a PR could be merged as the CI is not blocking if not required.

this is a missconfigured branch protection!
reporting back a pending on skiped is just wrong