Setting AWS Key and secret in value does not work

[jasonrichardsmith]

I have been testing woodpecker ci at codeberg. The S3 plugin did not work like this:

pipeline:
  upload:
    image: woodpeckerci/plugin-s3
    secrets: [aws_access_key_id, aws_secret_access_key]
    bucket: my-bucket-name
    access_key: $aws_access_key_id
    secret_key: $aws_secret_access_key
    source: public/**/*
    target: /target/location

But it does when you just leave the values as env vars:

pipeline:
  upload:
    image: woodpeckerci/plugin-s3
    secrets: [aws_access_key_id, aws_secret_access_key]
    bucket: my-bucket-name
    source: public/**/*
    target: /target/location

[jasonrichardsmith]

Not sure if this a bug in the plugin or a typo in documentation.

[anbraten]

Could you try:

pipeline:
  upload:
    image: woodpeckerci/plugin-s3
    secrets: [aws_access_key_id, aws_secret_access_key]
    settings:
      bucket: my-bucket-name
      access_key:
        secret: aws_access_key_id
      secret_key:
        secret: aws_secret_access_key
      source: public/**/*
      target: /target/location

[6543]

Note: we have to update plugin docus & pipelines to use new syntax

[anbraten]

The suggested answer should work. We also fixed some bugs related to the secret passing #842