search

woodpecker-ci / woodpecker

Woodpecker is a simple, yet powerful CI/CD engine with great extensibility.
https://woodpecker-ci.org
Apache License 2.0
4.1k stars 354 forks source link

live log view: let "auto follow" enable / disable #810

Closed 6543 closed 2 years ago

6543 commented 2 years ago

at the moment it's always enabled

abheekda1 commented 2 years ago

I think this could be implemented with a check box coupled with an empty element at the bottom of the build log that uses this function and updates either every interval or every time a new line is added.

abheekda1 commented 2 years ago

Maybe it could be added to the lowest line here? https://github.com/woodpecker-ci/woodpecker/blob/6ae7e2cc4f65edaa6382d4df9cc8f6c968e3d39e/web/src/components/repo/build/BuildLog.vue#L90-L92

6543 commented 2 years ago

I think on each time a new line is added with a delay to load segments if it goes fast?

6543 commented 2 years ago

cc @lafriks ?

lafriks commented 2 years ago

It could be easily added but any ideas where to place it?

anbraten commented 2 years ago

I would suggest to use a button similar at the same position as the download button as you will have enable auto follow for running jobs and download for finished jobs. It could just show an image like https://icones.js.org/collection/ic?s=baseline-file-download and the crossed if disabled.

lafriks commented 2 years ago

Yes but button should have different icon, this will be too confusing with donwload

lafriks commented 2 years ago

@anbraten could not find any better icon so just changed download icon to https://icones.js.org/collection/ic?s=baseline-download-offline