Remove File/VTES Sets (was:Bug with File/VTES Sets....)

[GoogleCodeExporter]

I did not used this feature much but from the fresh build from r41 + my
patch to imagePanel.cpp there is a issue with it.

What steps will reproduce the problem?
1. Make a fresh DB update with File/Update Database and don't use local
vtes.zip but DL a fresh new
2. Restart ARDB
3. Run File/VTES Sets...
4. Remove all sets but Night Of Reckogning
5. Search for a card using the Find input field of CardBrowser

What is the expected output? 
It hsould show matching cards

What do you see instead?
Error Dialog with msg Problem fetching card #XXXX

I see two issues in fact
1. the error message is probably a result of a missing reload of the card
tabel UI component after validate VTES Sets?

2. On Validate the VTES Sets... Dialog there is a huge CPU usage which is
the result of a bad DB design.

AFIK VTES Sets... actually move records around from card_crypt/card_library
to card_crypt_ignored/card_library_ignored

Years ago i made the db schema of ardb, see attachment.

Comment: I don't know how used is this feature but i thing it have to be
completely refactored. I would vote to remove this feature from UI for now
and add a new task to refactore this feature.

A new table IGNORED_SETS with a single field SET_ID should be added. The
VTES Sets... UI should only manipulate this simple table. CardBrowser table
 data fetching Queries should add additionnal conditions from this
IGNORED_SETS table

Original issue reported on code.google.com by meshee.k...@gmail.com on 13 Nov 2007 at 7:48

Attachments:

• database_structure.png

[GoogleCodeExporter]

Original comment by meshee.k...@gmail.com on 14 Nov 2007 at 7:56

• Added labels: Milestone-Ardb2.0

[GoogleCodeExporter]

I think this should be a V3.00 fix.  It is going to take a large re working of 
the
database to fix this.  Do you agree Meshee?

Original comment by graham.r...@gmail.com on 14 Nov 2007 at 8:06

[GoogleCodeExporter]

Team decision: remove feature from UI for v2.0 Create a new Issue to 
reintroduce this
feature on v3.0 with refactored code.

Original comment by meshee.k...@gmail.com on 14 Nov 2007 at 8:25

• Changed title: Remove File/VTES Sets (was:Bug with File/VTES Sets....)

[GoogleCodeExporter]

I will do the removal

Original comment by meshee.k...@gmail.com on 14 Nov 2007 at 6:39

• Changed state: Started

[GoogleCodeExporter]

revision 48 fix this issue.

I factored out the sql code to ardb_db_edition_filter.cpp and remove menu 
entries.

Tested ok on Linux/Debian

Original comment by meshee.k...@gmail.com on 27 Nov 2007 at 8:58

• Changed state: Fixed