fix windows

[Ashyni]

Hello,

Here is the changes necessary to fix windows https://github.com/woodruffw/ff2mpv/issues/26

Changes to ff2mpv.js aren't, it just add a tiny bit more information to the console.

Closes https://github.com/woodruffw/ff2mpv/issues/26.

[woodruffw]

This looks good, thanks. I left some small nitpicks. I'll also need to update the docs to emphasize that only the Python client is supported on Windows, but I'll take care of that after merge.

[Ashyni]

I new to this, forgive me for the unnecessary changes.

[woodruffw]

I new to this, forgive me for the unnecessary changes.

Not a problem at all, you're doing great! I'm just a stickler :slightly_smiling_face:

[woodruffw]

This looks great, thanks again. I'll merge now and cut a release either tonight or tomorrow.

[sbor23]

FYI I just set up ff2mpv and this fails on linux, specifically fedora 33 with python 3.9.0. It seems that CREATE_BREAKAWAY_FROM_JOB is windows only.

[stefan@thinkpad ~]$ ff2mpv.py
Traceback (most recent call last):
  File "/home/stefan/.local/bin/ff2mpv.py", line 7, in <module>
    from subprocess import Popen, CREATE_BREAKAWAY_FROM_JOB
ImportError: cannot import name 'CREATE_BREAKAWAY_FROM_JOB' from 'subprocess' (/usr/lib64/python3.9/subprocess.py)

Using the commit before solves the issue and I have working plugin.

[woodruffw]

Bleh, should have figured that that import wouldn’t work. Thanks, will issue a fix tomorrow.

Sent from mobile. Please excuse my brevity.

On Nov 3, 2020, at 7:04 PM, Stefan Borer notifications@github.com wrote:

 FYI I just set up ff2mpv and this fails on linux, specifically fedora 33 with python 3.9.0. It seems that CREATE_BREAKAWAY_FROM_JOB is windows only.

stefan@thinkpad ~]$ ff2mpv.py Traceback (most recent call last): File "/home/stefan/.local/bin/ff2mpv.py", line 7, in from subprocess import Popen, CREATE_BREAKAWAY_FROM_JOB ImportError: cannot import name 'CREATE_BREAKAWAY_FROM_JOB' from 'subprocess' (/usr/lib64/python3.9/subprocess.py) Using the commit before solves the issue and I have working plugin.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub, or unsubscribe.

[woodruffw]

@sbor23 Thanks again. Should be fixed on master as of https://github.com/woodruffw/ff2mpv/commit/ee396d36003ef52a83d4f600bb074cf68d32cf23.

[sbor23]

Awesome, slick add-on you have here!

[woodruffw]

Thank you for the kind words! Feel free to open a new issue if anything else breaks.

[Ashyni]

My bad on this one. I have zero knowledge in python.

[woodruffw]

Not a problem -- it was my mistake during reviewing 🙂. It didn't make it into a release, so the fallout was minor.