search

woodruffw / ff2mpv

A Firefox/Chrome add-on for playing URLs in mpv.
https://addons.mozilla.org/en-US/firefox/addon/ff2mpv/
Other
521 stars 52 forks source link

Error feedback #40

Closed Atemu closed 2 years ago

Atemu commented 3 years ago

Currently, when any part of the chain (ff2mpv.{js,py}, mpv[, youtube-dl]) encounters an error, ff2mpv silently fails.

Zero feedback. Either mpv opens or nothing happens.

This is especially annoying when an URL takes a while to be opened in MPV as one might wrongly conclude that it failed to open, try to open again and then be presented with two MPV instances of the same stream.

It would be very helpful if the addon told the user where things went wrong and provided a link to troubleshooting steps and the issue tracker.

woodruffw commented 3 years ago

I'm open to some discussion on this. The current lack of error feedback is (somewhat) intentional, as I wrote ff2mpv for my own purposes and use my own modified copy of the stock native client that sends a desktop notification when I play something:

https://github.com/woodruffw/dotfiles/blob/master/scripts/ff2mpv

That being said, it might be good to add notification support on the WebExtension side. I'd be open to including the notifications permission and using the APIs documented here: https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/user_interface/Notifications

woodruffw commented 3 years ago

(People can hash out the details on this, but I'm happy to accept a small PR that uses the notifications permission + APIs for error feedback).

benyaminl commented 2 years ago

@woodruffw can we close this issue then? I mean if other person tried to do the same, they will end up hitting the wall, or we an suggest them to implement to their user code themselves, at least at wiki?

related to https://github.com/woodruffw/ff2mpv/pull/68#issuecomment-1008231519

woodruffw commented 2 years ago

Yeah, we can close this for now. I forgot I had initially said yes to a small PR that uses the notifications permission, so I apologize for the confusion here.

And yes, please feel free to edit the wiki with that suggestion.