search

woodruffw / ff2mpv

A Firefox/Chrome add-on for playing URLs in mpv.
https://addons.mozilla.org/en-US/firefox/addon/ff2mpv/
Other
521 stars 52 forks source link

Not working in MacOS Brave Browser but working in Firefox #90

Closed LampPrinter closed 1 year ago

LampPrinter commented 1 year ago

OS information: MacOS Ventura Firefox version: 107 Brave version: 108 MPV version - 0.35

which ruby - /usr/bin/ruby which python - /opt/homebrew/bin/python which python3 - /opt/homebrew/bin/python3

This is how the Brave json looks like

iShot_2022-12-07_10 19 42

This is how the Firefox json looks like

iShot_2022-12-07_10 19 58

Have changed path of "mpv" to "/Applications/mpv.app/Contents/MacOS/mpv" in ff2mpv.py

Not sure how to debug it. Do not see any errors in MacOS console app or Brave developer tools.

Edit: Seems to be some issue with Brave Browser. Turning off adblock and on, it seems to working fine.

woodruffw commented 1 year ago

Seems to be some issue with Brave Browser. Turning off adblock and on, it seems to working fine.

That's very strange; adblocking should have no effect on this extension whatsoever.

I'm glad you were able to resolve it, and thanks for reporting anyways -- your report may help others in the future.