search

woodruffw / x_do.cr

Crystal bindings for libxdo (xdotool)
https://woodruffw.github.io/x_do.cr/
MIT License
18 stars 1 forks source link

Update for newer Crystals #8

Closed nickbclifford closed 3 years ago

nickbclifford commented 3 years ago

Currently, this shard cannot be installed on Crystal 1.0.0 without shards throwing a fit. The library itself works fine under newer Crystal, but one of the spec helpers used now-removed methods on Process.

This PR updates shard.yml and fixes the spec helper such that it now runs and passes.

woodruffw commented 3 years ago

Much appreciated, thanks!

nickbclifford commented 3 years ago

Thank you very much! Would you mind tagging a new patch version so it works with shards install? I believe shards might be having trouble with the v in the shard.yml version number.

woodruffw commented 3 years ago

Sure, no problem. I’ll cut a new tag in a bit.

Sent from mobile. Please excuse my brevity.

On Apr 10, 2021, at 1:38 PM, Nick Clifford @.***> wrote:

 Thank you very much! Would you mind tagging a new patch version so it works with shards install?

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub, or unsubscribe.

woodruffw commented 3 years ago

Okay, I've cut the v0.8.2 tag with your fix. Thanks again!

woodruffw commented 3 years ago

Ugh, sorry, I kept the v in. Will cut another patch...

woodruffw commented 3 years ago

Okay, 0.8.3 has been released.

nickbclifford commented 3 years ago

Installs perfectly now, thank you so much!