search

woodser / monero-java

Java library for using Monero
https://woodser.github.io/monero-java/javadocs/
MIT License
105 stars 39 forks source link

Collect reviews on API specification and update #17

Closed woodser closed 5 years ago

woodser commented 5 years ago

This issue documents the task of collecting peer review on this library's API specification and updating it accordingly.

woodser commented 5 years ago

Feedback from hyc_symas:

"You use uint for block height in several places. Should be ulong.

In many places where you use long, should be ulong.

You use long for nonce, should be uint.

Amount: BigInteger should be ulong.

difficulty and cumulative_difficulty should be same type.

A lot of hex values that you define as string probably should be dimensioned. Most of these are hex encoding of 256 bit hashes, so they should always be of exactly 32 bytes or 64 hex characters."

woodser commented 5 years ago

Spec updated.