search

woodser / monero-java

Java library for using Monero
https://woodser.github.io/monero-java/javadocs/
MIT License
105 stars 39 forks source link

MoneroWalletLight implementation #84

Open everoddandeven opened 5 months ago

everoddandeven commented 5 months ago

This PR enables monero wallet light jni implementation

woodser commented 2 months ago

Hey there, how's it going? Was wondering if these PRs are in or near a stable state to be able to merge, with basic functionality?

woodser commented 3 weeks ago

Just starting to test this with light wallet prs applied to monero-java, monero-cpp, and monero-project, but I'm getting a segfault in the full wallet running testCreateWalletRandomFull in TestMoneroWalletFull.java:

Stack: [0x000000016dbd8000,0x000000016dddb000],  sp=0x000000016ddd82d0,  free space=2048k
Native frames: (J=compiled Java code, j=interpreted, Vv=VM code, C=native code)
C  [libmonero-cpp.dylib+0x783110]  epee::wipeable_string::wipeable_string(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>> const&)+0x1c
C  [libmonero-cpp.dylib+0x25fffc]  monero::monero_wallet_full::move_to(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>> const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char>> const&)+0x118
C  [libmonero-java.dylib+0x1c06c]  Java_monero_wallet_MoneroWalletFull_saveJni+0xdc
j  monero.wallet.MoneroWalletFull.saveJni()V+0
j  monero.wallet.MoneroWalletFull.save()V+5
j  utils.TestUtils.getWalletFull()Lmonero/wallet/MoneroWalletFull;+173
j  TestMoneroWalletFull.getTestWallet()Lmonero/wallet/MoneroWallet;+0
j  TestMoneroWalletCommon.beforeAll()V+2
j  TestMoneroWalletFull.beforeAll()V+1

The existing tests will need to continue working before I can start testing and reviewing.

woodser commented 6 days ago

Hey, just letting you know that folks are becoming quite interested in your work. :)

They're discussing it in #monero-community-dev:monero.social. Hope to see you around soon!