search

woodyn1002 / more-fish

A Bukkit Plugin that makes your fishing more fun.
MIT License
28 stars 58 forks source link

Update to 1.13 #23

Closed piratjsk closed 5 years ago

piratjsk commented 6 years ago

After this changes plugin won't be working with older (below 1.13) spigot versions.

While it seems to work without any major bugs on 1.13, there still need to be some more testing done before releasing, so if someone would like to help and test this build, here is download link: https://www.dropbox.com/s/4dcy8qw23wjz79b/morefish-2.2-SNAPSHOT.jar?dl=0.

kaimokene commented 6 years ago

Hello. Fish shop says in config that its enabled while ingame it says its disabled. also the fish potion effects wont work since the syntax has changed for the command. I know the potion effect thing can be changed manually but id rather have it auto generate with right syntax. Currently thats all bugs that i have encountered there is a error that literally says only null in console when starting server but thats about it.

piratjsk commented 6 years ago

[...] Fish shop says in config that its enabled while ingame it says its disabled. [...]

Fish shop requires Vault and an economy plugin to work. If one of them isn't installed then enabling shop in config will take no effect. I've added some warnings about that on plugin startup in the latest version of my fork.
If you have installed Vault and an economy plugin and this problem is still present please provide name and version of economy plugin you are using.

[...] also the fish potion effects wont work since the syntax has changed [...]

I already fixed this (and few other things) in my fork, but didn't get to updating this pull request.
It also seems that original author is not interested in this plugin at this moment so I'll be just maintaining my fork.

[...] there is a error that literally says only null in console when starting server [...]

This also should be fixed in the latest version of my fork.

So, to sum up: