search

wooey / Wooey

A Django app that creates automatic web UIs for Python scripts.
http://wooey.readthedocs.org
BSD 3-Clause "New" or "Revised" License
2.11k stars 183 forks source link

fix HTML search in Django >= 1.8 #355

Closed Lioscro closed 2 years ago

Lioscro commented 2 years ago

The context_instance kwarg to render_to_string has been deprecated since Django 1.8. Added a check for the Django version to call the function with correct arguments.

Chris7 commented 2 years ago

Thanks for catching this -- you can actually just do the fix for the latest django, this is our current support of the next release: 'Django>=3,<4 ;python_version>="3.7"',

If its possible a unit test would be great to catch this in the future, but no worries if that is a tall ask as its already not covered.

Lioscro commented 2 years ago

Tests are in. Think I'll leave the version check for now since it can't hurt.