wooey / Wooey

A Django app that creates automatic web UIs for Python scripts.
http://wooey.readthedocs.org
BSD 3-Clause "New" or "Revised" License
2.14k stars 186 forks source link

Remove ModelDiffMixin #358

Closed Chris7 closed 2 years ago

Chris7 commented 2 years ago

We've having recursive issues due to this mixin. It's not worth the extra code and runs the risk of being stale data in multi-process environments, so it probably shouldn't have been used in the first place.

codecov-commenter commented 2 years ago

Codecov Report

Merging #358 (0748b51) into master (ff42881) will decrease coverage by 0.09%. The diff coverage is 31.74%.

@@            Coverage Diff             @@
##           master     #358      +/-   ##
==========================================
- Coverage   52.64%   52.54%   -0.10%     
==========================================
  Files          51       51              
  Lines        3349     3378      +29     
  Branches      546      549       +3     
==========================================
+ Hits         1763     1775      +12     
- Misses       1469     1484      +15     
- Partials      117      119       +2     
Flag Coverage Δ
unittests 52.51% <31.74%> (-0.10%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
wooey/models/mixins.py 87.50% <ø> (-3.41%) :arrow_down:
wooey/tests/test_views.py 0.00% <0.00%> (ø)
wooey/admin.py 85.18% <50.00%> (-6.31%) :arrow_down:
wooey/views/views.py 60.34% <77.77%> (+6.73%) :arrow_up:
wooey/models/core.py 80.00% <100.00%> (+0.09%) :arrow_up:
wooey/signals.py 64.40% <100.00%> (ø)
wooey/backend/utils.py 78.68% <0.00%> (+2.48%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.