wooga / atlas-build-unity

a gradle companion plugin for the wooga internal unity build system
Apache License 2.0
2 stars 2 forks source link

Improve codesigning identity verification #160

Closed Larusso closed 2 years ago

Larusso commented 2 years ago

Description

I implemented the FindIdentity utility only with full certificate names in mind. The value we pass to ImportCodeSigningIdentities task is wired to the exportOptions.plist signingCertificate field.

This field may or may not contain a full certificate name. From the xcodebuild manpage:

signingCertificate : String

For manual signing only. Provide a certificate name, SHA-1 hash, or automatic selector to use for signing. Automatic selectors allow Xcode to pick thenewest installed certificate of a particular type. The available automatic selectors are "Mac App Distribution", "iOS Developer", "iOS Distribution", "Developer ID Application", "Apple Distribution", "Mac Developer", and "Apple Development". Defaults to an automatic certificate selector matching the current distribution method.

This patch implements the missing logic to work with SHA-1 certificate ids and automatic selectors I also added support for the older iPhone Distribution and iPhone Developer selectors.

Changes