search

wooga / atlas-build-unity

a gradle companion plugin for the wooga internal unity build system
Apache License 2.0
2 stars 2 forks source link

Add support for build target string in BuildConfig #200

Closed Azurelol closed 1 year ago

Azurelol commented 1 year ago

Description

Add support for parsing the newer build target string in the BuildConfig.

Changes

Azurelol commented 1 year ago

I still don't understand why we get through all these changes just to rename a property that basically reflects the same information.

I know it looks redundant, for I came around to the same solution of having to serialize the string to the configuration. The reason why I didn't reuse the existing one is that I think batchModeBuildTarget was not the best descriptor: as I don't think we should name the field after one of the possible use cases, but instead of what it is. Hence buildTargetString.