Repository info returns empty provider if origin isn't github

wooga / atlas-github

Gradle plugin to publish artifacts to github

https://wooga.github.io/atlas-github/

Apache License 2.0

1 stars 3 forks source link

Repository info returns empty provider if origin isn't github #101

Closed Joaquimmnetto closed 3 years ago

Joaquimmnetto commented 3 years ago

Description

Fixed issue in RepositoryInfo.getRepositoryNameFromLocalGit() where gibberish was returned if git origin existed and wasn't from github.com. Now we check for github's domain presence in the provider.

Links to issue #99.

Changes

RepositoryInfo.getRepositoryNameFromLocalGit() provider now its empty when git origin isn't from github.

Joaquimmnetto commented 3 years ago

From the wording of the spec. It says it returns an empty repository name. But I guess you mean that the provider is empty?

Yeah, that is right, it returns a empty provider. I think it is better than to return a empty repository name. Also, it is the way it was described on the issue.