Closed Vampire closed 1 year ago
I bisected the problem and it is exactly the 6164a6fddb14dc126ccdb5b6d824dac406e5a919 commit with which it breaks.
I found the problem. It happens due to bug in Gradle that was fixed with 6.0 RC1 when you call .map(...)
on a TransformBackedProvider
, i.e. coming out of a .map(...)
call already.
It would be amazing if you could cut a 3.0.1 release with the changes in #145 soon. :-)
And the changes in #147 :-)
@Larusso any idea when you have time to look at those two?
Oh my. Github Notifications ... I just saw you last commend. So to understand you would need a fix on 3.x? We are currently getting ready to first support Gradle 7 (development0. We are lagging behind because of other dependencies) Let me check this for you.
Yes, a 3.0.1 with my two small PRs in would be amazing :-)
You just have to review and accept, the work is already done
I released your patches in 3.0.1
hope that helps you out! Thanks for your contributions
Perfect, thanks, that was fast now :-)
I have an old Gradle 5.6.4 project which I'm in the process of upgrading to 8.1.1. Up to now plugin 1.4.0 is applied, but that is not compatible with 8.1.1. To not mix too many changes in, I first wanted to upgrade the plugin to 3.0.0 before then upgrading Gradle to 8.1.1 as you state in the readme the plugin is compatible to Gradle 5+.
Unfortunatley, the Gradle 5 support is broken. If I apply
id("net.wooga.github") version "3.0.0"
to an otherwise empty 5.6.4 play project,gw help
strangely fails withI have no idea why the
repoInfo.repositoryNameFromLocalGit
called fromcauses the
git.remote.list().find {it.name == DEFAULT_REMOTE && it.url.contains(GITHUB_DOMAIN)}?: null
to be immediately evaluated, nor why the.remote
is considered to be called onRepositoryInfo
instead of onGrGit
. Especially as this even happens ifgrgitProvider
is an empty provider. It happens, whether there is a Git directory or not and whether there is a GitHub origin URL or not.And also with 2.0.0 the same problem is present already. So it seems as it is currently, there is no version that could be used with Gradle 5 and Gradle 8. :-( With Gradle 6.0 it works.