wooga / atlas-github

Gradle plugin to publish artifacts to github
https://wooga.github.io/atlas-github/
Apache License 2.0
1 stars 3 forks source link

Latest `master` code is broken for usage in convention plugins due to wrongly-scoped gradle-commons dependency #146

Closed Vampire closed 1 year ago

Vampire commented 1 year ago

The in f3d1ceff42b147e8528c1cb625d78c99e4d8e103 / #128 newly introduced gradle-commons dependency has a scope of runtime in the POM and is also in the runtimeElements variant in the Gradle Module Metadata.

That means that it is not part of the compile classpath of Gradle consumers.

So if you have a Gradle convention plugin that depends on this lib now, you get a compilation error, because the BaseSpec superclass of the GithubSpec class is missing in the compile classpath.

As BaseSpec is part of the API, gradle-commons needs to be an api dependency, not implementation.