search

wooga / atlas-release

gradle release plugin for atlas library packages
https://wooga.github.io/atlas-release
Apache License 2.0
0 stars 2 forks source link

Final release produces a Prerelease on when publish Github Release #74

Open Larusso opened 3 years ago

Larusso commented 3 years ago

Description

When executing a final release for a WDK project the actual github release is marked as prerelease. I checked the code and it looks like we changed the check values during the gradle upgrade process. Currently we check for project.status != 'final'. as seen here: https://github.com/wooga/atlas-release/blob/a16777d2f25d00213ca8f9732a74fec4be2d9897/src/main/groovy/wooga/gradle/release/ReleasePlugin.groovy#L238

The old code did check githubPublishTask.setPrerelease({ project.status != 'release' })

We need to fix this and maybe provide a test case to verify this.

Azurelol commented 3 years ago

Should it then check for (not final OR not release)?