search

wooga / atlas-unity

a Unity 3D gradle plugin
https://wooga.github.io/atlas-unity/
Apache License 2.0
14 stars 4 forks source link

Simpler, better fix for the generateSolution issue [ATLAS-1772] #197

Closed Joaquimmnetto closed 6 months ago

Joaquimmnetto commented 6 months ago

Description

Current generateSolution fix leaves a file behind in the project, which polutes the git, and potentially may add an extra script to the game. As this script is present when the solution is generated, its added to the solution as well, which can generate issues when the added script is removed in the cleanup task. As we need the rider extension anyway, its a better solution to just call it directly to generate a solution.

Changes

Joaquimmnetto commented 6 months ago

@Larusso Unity 2022 and upwards

Larusso commented 6 months ago

What is the official support of this plugin? I mean we have other things in here that work on older versions as well. We never really defined a min/max supported version. But this patch changes the implementation detail and a project without the proper unity version might suddenly fail