search

wooga / atlas-wdk-unity

Gradle Plugin to help wdk package development
https://wooga.github.io/atlas-wdk-unity
Apache License 2.0
0 stars 2 forks source link

Add support for AtlasBuildTools integration when added via UPM #67

Closed Larusso closed 1 year ago

Larusso commented 1 year ago

Description

This patch adds support to add the test build setup when the package AtlasBuildTools is added via upm as package com.wooga.atlas-build-tools.

There is a slight issue with this implementation as it evaluates the projectManifestFile property from the unity extension. The whole generation should be lazy here but that would make the setup more complicated and the test setup would need to be completely rewritten.

I opted for this solution since the plugin is opinionated anyways, and we usually can't override the location for the manifest file anyways.

Changes

Larusso commented 1 year ago

@Azurelol I think the setup is ok enough. I would actually change the whole implementation so these tests are no longer possible as Unit tests. I will merge as is.