search

wooga / eredis

Erlang Redis client
MIT License
628 stars 278 forks source link

subscribe reconnection #87

Open mpenet opened 8 years ago

mpenet commented 8 years ago

Hi,

Thanks for the lib. It's been a pleasure to use so far.

I am testing the pub/sub part of eredis, and from what I can see there' is no subscriber automatic reconnection, or am I missing something?

(STR: i connect to a redis instance, send some msg via redis-cli, receive them then, restart the redis-server, relaunch redis-cli, send more command -> nothing is received on the process listenening to subscribe.)

cheers,

Max

mpenet commented 8 years ago

Nevermind I got it working, but maybe this should be made automatic:

I had to manually eredis_sub:subscribe/2 once eredis_connected is emitted. I guess you maybe don't want to do channel bookkeeping internally hence the current approach.

Could be nice to document the behavior though, as https://github.com/wooga/eredis#reconnecting-on-redis-down--network-failure--timeout--etc makes it seems like it's all handled internally.