search

woohoolabs / yang

The efficient and elegant, PSR-7 compliant JSON:API 1.1 client library for PHP
MIT License
168 stars 13 forks source link

Introduce AttributeHydratorInterface #29

Closed holtkamp closed 4 years ago

holtkamp commented 4 years ago

As suggested in https://github.com/woohoolabs/yang/issues/28#issuecomment-602545847

kocsismate commented 4 years ago

Oh, I now see what you meant! Looks really promising after a quick look, but I'll have a look at it in a couple of days!

codecov[bot] commented 4 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@40e6a21). Click here to learn what that means. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #29   +/-   ##
=========================================
  Coverage          ?   97.91%           
  Complexity        ?      513           
=========================================
  Files             ?       29           
  Lines             ?     1056           
  Branches          ?        0           
=========================================
  Hits              ?     1034           
  Misses            ?       22           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 40e6a21...a836a26. Read the comment docs.

kocsismate commented 4 years ago

@holtkamp Sorry for this taking a long time. I like your solution, so merged the PR. :)