woohoolabs / yang

The efficient and elegant, PSR-7 compliant JSON:API 1.1 client library for PHP
MIT License
168 stars 13 forks source link

Allow set filter query param directly #31

Closed Insolita closed 3 years ago

Insolita commented 3 years ago

Fix #30

codecov[bot] commented 3 years ago

Codecov Report

Merging #31 (3bcc89a) into master (813747e) will increase coverage by 0.00%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #31   +/-   ##
=========================================
  Coverage     97.91%   97.92%           
- Complexity      513      514    +1     
=========================================
  Files            29       29           
  Lines          1056     1060    +4     
=========================================
+ Hits           1034     1038    +4     
  Misses           22       22           
Impacted Files Coverage Δ Complexity Δ
src/JsonApi/Request/JsonApiRequestBuilder.php 100.00% <100.00%> (ø) 50.00 <1.00> (+1.00)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 813747e...3bcc89a. Read the comment docs.

kocsismate commented 3 years ago

Thank you for the PR! I'll try to look at it in the upcoming days!

kocsismate commented 3 years ago

I've just merged your changes! :)

Insolita commented 3 years ago

What about adding a new tag?

kocsismate commented 3 years ago

Done!