search

woohoolabs / yang

The efficient and elegant, PSR-7 compliant JSON:API 1.1 client library for PHP
MIT License
168 stars 13 forks source link

Use Psr\Http\Client\ClientInterface as type #33

Closed holtkamp closed 1 year ago

holtkamp commented 3 years ago

As suggested in https://github.com/woohoolabs/yang/issues/32

holtkamp commented 2 years ago

@kocsismate I encountered this PR, could you consider merging it?

codecov[bot] commented 1 year ago

Codecov Report

Merging #33 (58ac40e) into master (8d48ee7) will not change coverage. The diff coverage is 0.00%.

:exclamation: Current head 58ac40e differs from pull request most recent head 7c78944. Consider uploading reports for the commit 7c78944 to get more accurate results

@@            Coverage Diff            @@
##             master      #33   +/-   ##
=========================================
  Coverage     97.92%   97.92%           
  Complexity      514      514           
=========================================
  Files            29       29           
  Lines          1060     1060           
=========================================
  Hits           1038     1038           
  Misses           22       22
Files Changed Coverage Δ
src/JsonApi/Client/JsonApiClient.php 0.00% <0.00%> (ø)
holtkamp commented 1 year ago

@kocsismate subtle but shameless bump?

kocsismate commented 1 year ago

@holtkamp OK, I'll try to find some time in the following days to merge your PR and release a new major version!