Closed fs613fs closed 3 years ago
Hi!
Thanks for the PR! However, the problem is that the current stable version (Yang 2.x) is still compatible with 7.2 where the return type variance is not supported, so the JsonApiResponse
return type is not compatible with PSR-18's ResponseInterface
.
Fortunately, Yang 3.0 is still in the works, and it requires PHP 7.4 at least, where variance is supported. So please change the target branch from master
to 3.0
.
Hi kocsismate,
Thank you for the comments. I have changed the target branch to 3.0.
Looks like there's a conflict. Can you please resolve it before I merge the PR?
Looks like there's a conflict. Can you please resolve it before I merge the PR?
done. thanks
Merging #34 (d069dc5) into 3.0 (dba8652) will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## 3.0 #34 +/- ##
=========================================
Coverage 97.84% 97.84%
Complexity 480 480
=========================================
Files 28 28
Lines 1019 1019
=========================================
Hits 997 997
Misses 22 22
Impacted Files | Coverage Δ | |
---|---|---|
src/JsonApi/Client/JsonApiClient.php | 0.00% <ø> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update dba8652...d069dc5. Read the comment docs.
Thank you for the PR! I'll try to release the change in the coming week(s).
I've just released 3.0.0-beta1 :)
Implemented PSR interface for JsonApiClient