Missing merge in branch for add client/lead activity diagram

[woojiahao]

Should include the merge from the branch. Missing this could lead to confusion on the user end as this is invalid notation

Same thing noticed for convert commands

[nus-se-script]

Team's Response

As mentioned here, it is acceptable to have multiple end points.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

• [x] I disagree

Reason for disagreement: I don't think using prof's words out of context is a valid justification for completely missing the merge node of the activity diagram. Yes, I understand that you can have multiple end nodes in an activity diagram, that is not what this report is about. This report raises the issue of missing the merge node entirely when a branch node is already used.

While the textbook does mention that omitting the merge node is an acceptable simplification, they only occur if the branches end up converging to the same end node, which the team did not use for their activity diagram, instead, using two separate end nodes. This creates obvious ambiguity and as a result, this should not be Rejected as the diagram can definitely be updated to more accurately reflect the program.

---