search

woojiahao / pe

1 stars 0 forks source link

Add a lead error case message is incorrect in DG #5

Open woojiahao opened 12 months ago

woojiahao commented 12 months ago

The error message expected does not include the missing prefix of k/

The error message given is:

Invalid command format! 
addlead: Adds a lead to the address book. Parameters: n/NAME p/PHONE e/EMAIL a/ADDRESS k/KEY_MILESTONE [m/MEETING_TIME] [t/TAG]...
Example: addlead n/John Doe p/98765432 e/johnd@example.com a/311, Clementi Ave 2, #02-25 k/01/12/2023 m/10/10/2023 14:30 t/classmate
nus-pe-script commented 11 months ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Unable to detect prefix k/

image.png

image.png

When user input multiple prefix for example: e/ in this case, the system will tell the user there is a multiple prefix. However when user want to add client but he accidentaly add one more field which is key_milestone, then the system was unable to catch this error, which might cause confusion to the user.

[original: nus-cs2103-AY2324S1/pe-interim#3475] [original labels: severity.Low type.FeatureFlaw]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Thanks for pointing this out, we do agree that the error shown is wrong. However the UG already specified that Clients should not have a key milestone field thus the "k/" should not have been added. We intend to fix this error message in the future iterations but it is not a very urgent issue and the user will rarely make such a mistake, thus we have assigned this issue as "NotInScope".

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

## :question: Issue response Team chose [`response.NotInScope`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]
## :question: Issue type Team chose [`type.FeatureFlaw`] Originally [`type.DocumentationBug`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]