search

wookayin / expt

Experiment. Plot. Tabulate.
MIT License
68 stars 6 forks source link

PyPi Release #17

Closed vwxyzjn closed 1 year ago

vwxyzjn commented 1 year ago

Hi @wookayin, any chance you could make a release on commit https://github.com/wookayin/expt/commit/ab538316b3e33c7c6acda16da68cbc6e9f05d49a? I am trying to make a pypi release at openrlbenchmark, and it does not allow me use expt's github link as the dependency.

wookayin commented 1 year ago

Is there any specific commit or new feature you are relying on in your project past the v0.4.1 release, if any, so I can consider a backport release v0.4.2? That specific commit seems the one right before the rust extension is introduced.

vwxyzjn commented 1 year ago

That's just the latest commit that is still installable without rust. If there is another more appropriate commit candidate, feel free to use that :)

vwxyzjn commented 1 year ago

FWIW, 0cd947f8c5fc66598e578ce8a394c5f522f060bd commit has worked for me, too.

wookayin commented 1 year ago

So what I was wondering is if using the stable release of expt on PyPI (expt==0.4.1) is an option for you. Have you tried v0.4.1 by any chance? I don't remember any particular critical bugfix since then.

I am making a lot of changes on a 0.5.x version (including some breaking changes), some of which I'm not sure yet I'm fully confident about them so I would be a bit hesitant about making hasty releases.

wookayin commented 1 year ago

As a last resort, making a pre-release (alpha version) would be another option -- without the rust extension.

vwxyzjn commented 1 year ago

Oh actually the existing release worked! I think previously I was working with plotting the median curve, but for this release I am not using it.

wookayin commented 1 year ago

Yes, but the median curve #5 is included in v0.4.0.

vwxyzjn commented 1 year ago

Ah I see. Then all is good with me. Sorry for the extra trouble.