search

wookiehangover / jshint.vim

JSHint fork of jslint.vim
Other
194 stars 45 forks source link

Fix some bugs with the comment handling. #14

Closed usrbincc closed 11 years ago

usrbincc commented 11 years ago

Some bugfixes for my previous pull request.

Amazingly, I actually did test that previous code, but clearly I wasn't thorough enough about it. Sorry about that. Here's a slightly more comprehensive test:

# run from the root of the working directory.
sed -ne '/function [a-z]\+comments/,/^}/p' \
  ftplugin/javascript/jshint/runner.js \
  > test-comment-handling.js
cat >> test-comment-handling.js <<"END"
var tests = [
  // should be allcomments
  '// 1\n// 2',
  '/* 1 **//*jshint 2*/\n/** /* 3 */',
  '  //\n//// \n/*\n"// " */',
  // should not be allcomments
  '/**//\n//* 1\n2 *// 2',
  '//* 1\n"/* should not be removed */"// 2 /* */ 2',
  '/* 1 */"// should not be removed"/* 2 */',
  '4/* 1 */2/*jshint 2*/question\n/* 3 */answer'
];
tests.forEach(function(x) {
  if (allcomments(x)) {
    console.log('allcomments');
  }
  console.log('[%s]', removecomments(x));
});
END

node test-comment-handling.js