wookiehangover / jshint.vim

JSHint fork of jslint.vim
Other
194 stars 45 forks source link

JSHint plugin should populate Vim's location list instead of quick fix list #36

Open acepukas opened 10 years ago

acepukas commented 10 years ago

While linting a js file with JSHint, it makes more sense to use the location list instead of the quick fix window.

One scenario that illustrates this is when users grep for some pattern within their project files, using a different plugin that populates the quick fix list with results. When the quick fix window pops up, the user will select a result from the list and jump directly to that result in another file. If that file happens to be a javascript file, the JSHint plugin lints the file automatically once the buffer is fully read. This action overwrites the contents of the quick fix window that contained the grep results, forcing the user to grep again, which is inconvenient.

Using the location list for linting prevents interference with quick fix enhanced greping, and other actions that are concerned with listing locations from multiple files (compiling, etc.). Besides, when you are linting in an editor, you're usually only concerned with the contents of that particular file.

amarshall commented 9 years ago

Note that a temporary workaround for the problem of jshint overriding the quickfix list is to get g:JSHintUpdateWriteOnly=1 to prevent jshint.vim from overwriting the quickfix at load. But yes :+1: on this.

patrickmcelwee commented 9 years ago

+1

eddiemonge commented 9 years ago

@acepukas interested in updating this still?

acepukas commented 9 years ago

Oh jeez. I've since abandoned jshint for eslint. I'll get reacquainted with this plugin and wrap this up.