search

wookoinc / react-native-popover-tooltip

ReactNative component - tooltip menu
MIT License
63 stars 63 forks source link

PropTypes is deprecated in React 15.5 #5

Closed FedeG closed 7 years ago

FedeG commented 7 years ago

I updated react-native-tooltip-menu compatibility for react 16 in this merge: https://github.com/alimek/react-native-tooltip-menu/pull/7

FedeG commented 7 years ago

I'm develop to update this repository in this fork: https://github.com/Devecoop/react-native-popover-tooltip

FedeG commented 7 years ago

This issue are fixed in this pull request: https://github.com/wookoinc/react-native-popover-tooltip/pull/6

luqiuyuan commented 7 years ago

FedeG, sorry to the late reply. Thanks for sending the PR. However, I merged your change manually, since the PR contains some other changes.

beetlebum commented 7 years ago

@luqiuyuan seems like only index.js was modified, but popovertooltipitem.js also contains references to React.PropTypes and won't work in React 16.

ChildishDanbino commented 7 years ago

I have an open PR for this issue. Please see changes here https://github.com/wookoinc/react-native-popover-tooltip/pull/11/files

luqiuyuan commented 7 years ago

@beetlebum Yes, it was my mistake, I forgot to change popovertooltipitem.js. However, I have merged the PR from @Daadler6 , it should be OK now.

ChildishDanbino commented 7 years ago

@FedeG can we get this issue closed?