search

wooksong / contributon2019-nns

7 stars 6 forks source link

[Ext/Decoders/BoundingBox] Bug: enum variables are always larger than -1 #16

Closed wooksong closed 5 years ago

wooksong commented 5 years ago 
 382     if (NULL == param || *param == '\0' || bdata->mode < 0) {                   
 383       GST_ERROR ("Please set the valid mode at option1");                       
 384       return FALSE;                                                             
 385     }

bdata->mode is a variable of enum type so that it is always a positive value or zero. Some compilers (i.e., clang) would complain about it. Need to fix this logical bug.

niklasjang commented 5 years ago

https://github.com/nnsuite/nnstreamer/pull/1758

https://github.com/nnsuite/nnstreamer/pull/1758/commits/693048f24de084b0bb810e51192a2e5476b14586

PR 결과 기다렸다가 리포트 하겠습니다

wooksong commented 5 years ago

Merged!