Closed wooksong closed 5 years ago
num-buffers : Number of buffers to output before sending EOS (-1 = unlimited)
flags: readable, writable
Integer. Range: -1 - 2147483647 Default: -1
https://github.com/nnsuite/nnstreamer/pull/1758
reference에서 num-buffers 변수 타입 확인하고 guint를 gint로 바꾸었습니다. buffer_index 변수도 num-buffers와 비교 구문이 있어서 똑같이 gint로 바꾸어 주었습니다.
아직 PR 결과 기다리고 있습니다.
Merged!
In ./tests/nnstreamer_sink/unittest_sink.cpp, the variable, num_buffers, in the struct TestOption is treated as int. It is very dangerous.
For example,
could we guarantee that this code would work as we intended?