search

wooorm / dictionaries

Hunspell dictionaries in UTF-8
MIT License
1.21k stars 398 forks source link

Add `@types/leb128` #62

Closed remcohaszing closed 9 months ago

remcohaszing commented 9 months ago

There’s no need anymore to use @ts-expect-error for the leb128 import, or to cast the types its functions return.

wooorm commented 9 months ago

Thanks for the types but it’s just a little script that I saved here for future reference for when Node supports WASM I can actually implement it. It doesn’t run. Not sure if leb128 is needed then. It seems useful but also not maintained? 🤷‍♂️

Feels a bit weird to add dev-dependencies that aren’t used?

wooorm commented 9 months ago

Oh I guess TS still checks it all?

remcohaszing commented 9 months ago

Technically you could use @types/leb128, but not leb128 if it’s just for TypeScript. Personally I would keep it, as it’s needed to run a script that is part of this repo.