search

wooorm / markdown-rs

CommonMark compliant markdown parser in Rust with ASTs and extensions
https://docs.rs/markdown/1.0.0-alpha.18/markdown/
MIT License
836 stars 41 forks source link

Fix serde #74

Open sshwy opened 12 months ago

sshwy commented 12 months ago

This pr is trying to fix #72.

wooorm commented 12 months ago

Can you add a a test that breaks before your change, and works now? Thanks.

sshwy commented 12 months ago

Can you add a a test that breaks before your change, and works now? Thanks.

I've added a simple test for it. I know it is not sufficient to prove that the result of serialization is consisitent with mdast's type definition. However I'm getting a little busy these days, so it may take a long time for me to write a more thorough test if you urge :).

wooorm commented 12 months ago

Tests fail, I think this is because you’re now testing serde, but it’s an optional dependency, and should be a required dev-dependency?